Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs minor cleanups in changeStreamReader.js, improving logging, stream handling, and async consistency.
- Swapped
console.logcalls for structuredlog.i/log.w - Added safety checks around closing streams and finalized cleanup
- Introduced
awaitonprocessBadRangecalls for correct async flow
Comments suppressed due to low confidence (2)
api/parts/data/changeStreamReader.js:186
- Ensure that the enclosing function is declared async; using
awaitin a non-async context will cause a syntax error.
await this.processBadRange({name: this.name, cd1: token.cd, cd2: next_token.cd}, this.failedToken);
api/parts/data/changeStreamReader.js:284
- This closing brace appears to prematurely close the
tryblock, leading to a 'catch without try' syntax error. Please remove or reposition it to balance the block correctly.
}
Cookiezaurs
approved these changes
Jul 1, 2025
Cookiezaurs
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.